Check GitHub authentication before branch resolution in ParseGitHubUrl #6478
+119
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: vhvb1989 <24213737+vhvb1989@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve azd ai agent init UX for authentication errors
Check GitHub authentication before branch resolution in ParseGitHubUrl
Jan 8, 2026
vhvb1989
requested review from
JeffreyCA,
rajeshkamal5050 and
tg-msft
as code owners
vhvb1989
approved these changes
Jan 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where azd ai agent init fails with a misleading error message about invalid branch names when GitHub authentication is missing or expired. The fix ensures users are prompted to authenticate before branch resolution attempts.
Key Changes
- Added
ensureGitHubAuthenticated()helper function to check and trigger GitHub authentication - Integrated authentication check into
ParseGitHubUrl()before branch API calls for raw/blob/tree URLs - Updated all existing tests to mock authentication status responses
- Added comprehensive test for unauthenticated scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cli/azd/pkg/templates/gh_source.go | Added ensureGitHubAuthenticated() function and integrated auth checks before branch resolution in ParseGitHubUrl() |
| cli/azd/pkg/templates/gh_source_test.go | Updated all tests to mock gh auth status, added new test Test_ParseGitHubUrl_NotAuthenticated to verify login flow |
Contributor
|
Fix looks good on my end: 
@copilot can you fix the golint error? |
Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com>
Contributor
Author
... Fixed in commit 2a62ff2. The struct fields in |
JeffreyCA
approved these changes
Jan 8, 2026
Member
|
/check-enforcer evaluate |
This was
linked to
issues
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan: Fix ParseGitHubUrl to check authentication before branch resolution ✅
Summary
This fix ensures that
ParseGitHubUrlchecks for GitHub authentication before attempting to resolve branch names via API calls. This provides users with a clear login prompt instead of cryptic error messages when they're not authenticated or have bad/expired credentials.Latest Change
Fixed struct field alignment in
Test_ParseGitHubUrl_NotAuthenticatedto pass gofmt checks. TheStdoutandStderrfields now align properly withExitCode.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.